django-contrib-comments icon indicating copy to clipboard operation
django-contrib-comments copied to clipboard

Published 20 hours ago • verified publisher icon django

Converting post_comment to Class Based views

Open SudShekhar opened this issue 8 years ago • 3 comments

Hi,

I was just wondering if there are any plans to migrate post_comment function to class based views? I am customizing django-contrib-comments to allow for file uploads and will need to copy paste the whole function. Was thinking that it would be much easier if we had the same thing as a class.

Any particular reason why it has not been done yet? Will pull requests for the same be welcome?

Thanks!

SudShekhar avatar Apr 17 '16 02:04 SudShekhar

I also think that converting it to a class-based view would add value. So yes, patch welcome!

claudep avatar Apr 17 '16 12:04 claudep

Cool. I will try to write the new view and create a patch over the coming weekend.

SudShekhar avatar Apr 18 '16 04:04 SudShekhar

Just added a pull request #170 . A class based view would make customizing the view a lot more straight forward.

thomst avatar Jul 13 '21 17:07 thomst