django-contrib-comments
django-contrib-comments copied to clipboard
converted the post_comment view to a class based view building on top of the generic FormView
As discussed in issue #82 a classed based view would ease the task of customize the post_comment view. I took the effort and rebuild the logic of the post_comment view as a class based view. I was anxious to not alter the logic of the routine itself. Just migrated it into the scructure of the generic FormView.
@claudep it seems Travis CI has migrated from .org to .com for open source repositories and also uses GitHub actions integration (from what I can tell). Can you re-enable this repository on travis-ci.com b/c I don't seem to have permissions to do so.
Some comments requested.
I am also not seeing any results reported by Travis CI here so can't judge how well does the new implementation function wrt the existing test suite.
tox run well on my changes:
...
py35-django22: commands succeeded
py36-django22: commands succeeded
py37-django22: commands succeeded
py38-django22: commands succeeded
py39-django22: commands succeeded
py36-django30: commands succeeded
py37-django30: commands succeeded
py38-django30: commands succeeded
py39-django30: commands succeeded
py36-django31: commands succeeded
py37-django31: commands succeeded
py38-django31: commands succeeded
py39-django31: commands succeeded
py36-django32: commands succeeded
py37-django32: commands succeeded
py38-django32: commands succeeded
py39-django32: commands succeeded
py36-master: commands succeeded
py37-master: commands succeeded
py38-master: commands succeeded
py39-master: commands succeeded
congratulations :)
Tests should be runable again now.