daphne Use code when rejecting connection

Use code when rejecting connection

Open daveisfera opened this issue 2 years ago • 4 comments

trafficstars

Fixed #486

Oct 06 '23 00:10 daveisfera

Can we add a regression test for this change?

Oct 07 '23 06:10 carltongibson

I'm not familiar with the tests. Can you point me to where that would be added?

Oct 09 '23 16:10 daveisfera

This PR is wrong. Daphne doesn't support WebSocket Denial Response. The status code 403 is correct.

The message["code"] is not a HTTP status code.

Dec 19 '23 17:12 Kludex

This PR is wrong. Daphne doesn't support WebSocket Denial Response. The status code 403 is correct.

The message["code"] is not a HTTP status code.

I'm not sure what that's supposed to mean. I've tested this change and it works

Dec 19 '23 18:12 daveisfera

Closing as per ticket.

Oct 08 '24 14:10 carltongibson