channels icon indicating copy to clipboard operation
channels copied to clipboard

Published 20 hours ago • verified publisher icon django

improve group_name and channel_name validation error message(#1229)

Open ericls opened this issue 6 years ago • 1 comments

This is to include the maximum length in the error message when validating group and channels names. Also found that invalid_name_error is defined but never used. This PR also utilizes that to format error messages. Some tests were added.

Closes #1229.

ericls avatar Jan 26 '19 15:01 ericls

Hi @carltongibson and @jpic, Sorry for the delay and thanks for the review and suggestions. I do plan to finish this PR by the end of tomorrow (eastern time)

ericls avatar Feb 04 '19 16:02 ericls

This needs to be rebased after #1792

carltongibson avatar Sep 02 '22 10:09 carltongibson

This needs to be rebased after #1792

Thanks for the reminder, I've rebased the changes on top of the latest main. I've also noticed that the current error message is missing a .format() call, and would throw TypeError: 'str' object is not callable

ericls avatar Sep 04 '22 20:09 ericls