valid_group_name throwing wrong exception message

[ericls]

valid_group_name always throws the message Group name must be a valid unicode string containing only ASCII alphanumerics, hyphens, or periods., even if the actual error is group name being too long. Would be helpful if we throw a different message or include the length limit in the message.

[andrewgodwin]

I agree, it would be helpful, this wouldn't be too hard for someone to write a patch for.

[ericls]

I'll submit a PR shortly. Also, is it documented anywhere why there's a restriction on the length of the names? Thank you!

[andrewgodwin]

There's no specific reason, but it's so the names can be more easily portable across different backends. Unlimited length names would be hard to deal with in some places.

[jpic]

Thank you for your report and patch proposal.

Please remember that after code and test comes refactor, and that also applies on tests.

Also we need the change documented.