django-wiki icon indicating copy to clipboard operation
django-wiki copied to clipboard

Automatic link detection should skip text inside markdown link markup

Open citxx opened this issue 7 years ago • 5 comments

Currently this:

[C.Python](wiki:/my-article)

is converted into this:

<a class="wikipath linknotfound" href="/wiki/my-article"></a>
<a href="http://C.Python"><span class="fa fa-external-link"></span><span>C.Python</span></a>

but should be converted into this:

<a class="wikipath linknotfound" href="/wiki/my-article">C.Python</a>

citxx avatar Jun 27 '18 18:06 citxx

Just checked that I can reproduce on master as well

citxx avatar Jun 27 '18 18:06 citxx

Oh that looks super weird. It would be great with a PR that introduces some proper unit testing of this markdown extension.

benjaoming avatar Jun 28 '18 11:06 benjaoming

Thanks for finding this!

benjaoming avatar Jun 28 '18 11:06 benjaoming

Would you be able to work on it?

benjaoming avatar Jun 28 '18 11:06 benjaoming

I most probably won't be able to work on this until late July. If it won't be fixed by that time I'll probably take it.

Currently I went with a dirty hack of replacing C with a cyrillic С.

citxx avatar Jun 28 '18 14:06 citxx