django-nyt icon indicating copy to clipboard operation
django-nyt copied to clipboard

Dont raise ValidationError when there is no default settings object

Open benjaoming opened this issue 5 years ago • 1 comments

Don't raise ValidationError when there is no default settings object, make current one the default.

Not sure yet if this change should go in, but opening the PR to flag for later.

benjaoming avatar Feb 16 '20 10:02 benjaoming

Codecov Report

Merging #95 into master will decrease coverage by 0.04%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   76.21%   76.17%   -0.05%     
==========================================
  Files          26       26              
  Lines         555      554       -1     
==========================================
- Hits          423      422       -1     
  Misses        132      132
Impacted Files Coverage Δ
django_nyt/models.py 84.55% <0%> (-0.13%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e0cd63a...302e7d0. Read the comment docs.

codecov-io avatar Feb 16 '20 10:02 codecov-io