django-nyt

django-nyt copied to clipboard

Support django-channels 2 - this PR is looking for someone to take over and finish the work

13

I want to share upgraded version that work with channels 2. Sorry, It's my first pull request and I am easy in license and, can u help me with it....

yevheniidehtiar

Dont raise ValidationError when there is no default settings object

1

Don't raise ValidationError when there is no default settings object, make current one the default. Not sure yet if this change should go in, but opening the PR to flag...

benjaoming

Channels 2

2

It looks like you're still using Channels 1. ``` Internal Server Error: /wiki/create-root/ Traceback (most recent call last): File "$PROJ_VENV/lib/python3.9/site-packages/django/core/handlers/exception.py", line 34, in inner response = get_response(request) File "$PROJ_VENV/lib/python3.9/site-packages/django/core/handlers/base.py", line...

AstraLuma

CommandError: You have not set ASGI_APPLICATION, which is needed to run the server.

1


darkane188

This has silently failed. Not sure how to handle it. Perhaps the current tests don't even use channels. https://github.com/django-wiki/django-nyt/pull/88 ``` py36-django30 run-test: commands[0] | sh -c '! python test-project/manage.py makemigrations...

benjaoming

It would be nice to add support of web-push notifications. Many users prefer push notifications to email notifications. Users should have an option to receive via push or email or...

mhozza

Example of subscribing to an event w/ channels

3

I know this isn't an actual issue, but wondering if anyone has a sample that includes how to setup events and then allow uses to subscribe/unsubscribe to them. Cheers, Greg

lowegreg

_notification_type_cache on NotificationType seems to cause errors with tests

7

In the tests for my application it seems that NotificationType is cleared after running each TestCase. This leads _notification_type_cache to no longer be valid. My current workaround is to manually...

mikhuang

Notification Improvements?

2

Hey there, I've been running an older fork of `django-nyt` with a few tweaks. I have to update my fork to the latest build anyway so I thought I'd check...

dwasyl

Instead of boggling the user's mind with weather or not these parameters should be supplied as objects or FK integers etc, let's 1) force that they are integers or strings...

benjaoming