django-oscar-accounts icon indicating copy to clipboard operation
django-oscar-accounts copied to clipboard

Purpose of `increment_blocks`.

Open benmurden opened this issue 5 years ago • 1 comments

https://github.com/django-oscar/django-oscar-accounts/blob/e03ecdf8499736462d00690e74e15f4608a09fdd/src/oscar_accounts/abstract_models.py#L487-L489

There is no total_blocks property on this model, so are inheriting classes meant to implement it, or is this old code that can be removed?

benmurden avatar Mar 24 '19 00:03 benmurden

It looks like it was never properly implemented (see https://github.com/django-oscar/django-oscar-accounts/commit/76d59317c82b5798844e51292bc9f07a1ee55665) and has always been broken. Looks like record_blocked_request isn't used anywhere either so the simplest path at this stage is just to remove this code.

solarissmoke avatar Mar 25 '19 07:03 solarissmoke