django-oscar-accounts icon indicating copy to clipboard operation
django-oscar-accounts copied to clipboard

Not Oscar-independant

Open juanigsrz opened this issue 6 years ago • 11 comments

Running

pip install django-oscar-accounts (adding oscar_accounts to installed apps) python manage.py migrate oscar_accounts

Yields:

SystemCheckError: System check identified some issues:

ERRORS: oscar_accounts.Account.product_range: (fields.E300) Field defines a relation with model 'offer.Range', which is either not installed, or is abstract. oscar_accounts.Account.product_range: (fields.E307) The field oscar_accounts.Account.product_range was declared with a lazy reference to 'offer.range', but app 'offer' isn't installed.

juanigsrz avatar Apr 04 '18 22:04 juanigsrz

Yeah, unfortunately it isn't. I've actually removed the suggestion that it is from the documentation on master - unless someone has the time to actually make it oscar-independent I think it will probably have to stay that way...

solarissmoke avatar Apr 05 '18 04:04 solarissmoke

Looking at the code for a bit i think it only references django-oscar for its user model and an exception class. It also references offer.Range with a ForeignKey which i think could be deleted. So yeah. making it oscar-independant might not be really hard after all.

juanigsrz avatar Apr 05 '18 10:04 juanigsrz

Would you be able to make a PR? More than happy to review/merge it if you are.

solarissmoke avatar Apr 05 '18 10:04 solarissmoke

Right now i'm busy with two other projects, but i will try to do it if no one else does.

juanigsrz avatar Apr 05 '18 10:04 juanigsrz

what's the possible solution here? If you have time i can help you with this.

SalahAdDin avatar Apr 06 '18 11:04 SalahAdDin

Hi, I would be really interested in using this as a standalone. @juanigsrz I checked and removing the 'offer.Rang' foreign key doesn't seem so easy, or at least I am not sure on how to actually handle that...

millerf avatar Apr 08 '19 10:04 millerf

Hey @millerf , i personally ended up dropping it and made my own double entry system based on other working projects. Sorry i can't help you.

juanigsrz avatar Apr 08 '19 13:04 juanigsrz

No worries... I just reused it and removed the product_range attribute...

millerf avatar Apr 08 '19 13:04 millerf

As @solarissmoke said, feel free to make a PR for review, i'm sure it'll be helpful to a lot of people!

juanigsrz avatar Apr 08 '19 13:04 juanigsrz

I'll just leave it here: https://github.com/PekopT/django-oscar-accounts

PekopT avatar Mar 26 '20 22:03 PekopT

I'll just leave it here: https://github.com/PekopT/django-oscar-accounts

Love the work, any plans to release the work on pypi?

TurnrDev avatar Nov 05 '20 15:11 TurnrDev