django-rest-framework-json-api icon indicating copy to clipboard operation
django-rest-framework-json-api copied to clipboard

Published 20 hours ago • verified publisher icon django-json-api

fixes attribute naming in filter backend and AutoSchema

Open jokiefer opened this issue 3 years ago • 1 comments

Fixes #

Description of the Change

Checklist

  • [x] PR only contains one change (considered splitting up PR) ~- [ ] unit-test added~ ~- [ ] documentation updated~
  • [x] CHANGELOG.md updated (only for user relevant changes)
  • [x] author name in AUTHORS

jokiefer avatar Feb 06 '22 18:02 jokiefer

@jokiefer Wanted to follow up whether you are still interested in working on this PR?

sliverc avatar Apr 26 '22 17:04 sliverc

I had some time at hand and wanted to make sure that this PR lands in the next version (which is hopefully released soon, waiting for DRF to release a new version supporting Django 4.1). I added a test and made minor adjustments to the PR.

When adding the test, I noticed that there was actually an error in the code. It called format_field_names instead of format_field_name so this did not work. Once again, a great example of how important tests are.

Anyway. Thanks for bringing this up and working on it.

sliverc avatar Sep 06 '22 20:09 sliverc