pysolr icon indicating copy to clipboard operation
pysolr copied to clipboard

Make _to_python recursive for lists and tuples

Open tuky opened this issue 11 years ago • 10 comments

_to_python's behavior on lists / tuples to only convert the first value seems very arbitrary. It even fails with an IndexError on empty lists. This PR also fixes multivalued dynamic fileds in e.g. Solr with haystack: they have no convert function and therefore call this _to_python method.

tuky avatar Sep 13 '13 16:09 tuky

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 05 '18 14:06 stale[bot]

It would still be nice to see this upstream. Does anything speak against this change?

tuky avatar Jun 05 '18 14:06 tuky

It does look like a reasonable change, although it'd need a corresponding change for consumers like e.g. Haystack. That might be worth cutting 4.x.

acdha avatar Jun 05 '18 14:06 acdha

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 03 '18 17:09 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 03 '18 14:12 stale[bot]

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@fcbf73e). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #94   +/-   ##
=========================================
  Coverage          ?   94.49%           
=========================================
  Files             ?        7           
  Lines             ?     1289           
  Branches          ?        0           
=========================================
  Hits              ?     1218           
  Misses            ?       71           
  Partials          ?        0
Impacted Files Coverage Δ
pysolr.py 89.9% <100%> (ø)
tests/test_client.py 99.61% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fcbf73e...90b9e4f. Read the comment docs.

codecov[bot] avatar Dec 17 '18 22:12 codecov[bot]

Codecov Report

Merging #94 into master will increase coverage by 0.16%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   94.31%   94.48%   +0.16%     
==========================================
  Files           7        7              
  Lines        1338     1341       +3     
==========================================
+ Hits         1262     1267       +5     
+ Misses         76       74       -2     
Impacted Files Coverage Δ
pysolr.py 89.77% <100.00%> (+0.32%) :arrow_up:
tests/test_client.py 99.63% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 493a9a0...3ebb453. Read the comment docs.

codecov[bot] avatar Dec 17 '18 22:12 codecov[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 20 '19 16:03 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 26 '19 17:06 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 24 '19 18:09 stale[bot]

Please rebase.

cclauss avatar Apr 26 '23 08:04 cclauss