django-haystack icon indicating copy to clipboard operation
django-haystack copied to clipboard

Create new release with Django v4 and v5 support

Open JanMalte opened this issue 3 years ago • 6 comments

Please publish a new release with django v4 support, which is already merged into the master branch.

See: #1826

JanMalte avatar Nov 30 '22 13:11 JanMalte

https://github.com/django-haystack/django-haystack#experimental-support-for-django-v50

cclauss avatar Dec 07 '23 08:12 cclauss

New GitHub release here: https://github.com/django-haystack/django-haystack/releases/tag/v3.3b1

I might need to update this if I missed part of the PyPI action setup. I'm trying to bring this into alignment with pysolr.

acdha avatar Dec 07 '23 17:12 acdha

@cclauss what's the timeframe for incorporating this in a PyPl release?

dustinblanchard avatar Jan 10 '24 21:01 dustinblanchard

@acdha Is this planned at any point?

dustinblanchard avatar Jan 17 '24 18:01 dustinblanchard

@dustinblanchard There are three pinned issues at https://github.com/django-haystack/django-haystack/issues

Once the first two are fixed then I think we should be able to progress on this one.

cclauss avatar Jan 17 '24 18:01 cclauss

@cclauss Since these issues seem pretty meaty, would it be possible to add a beta or pre-release tag so we could use the current version with hashing enabled?

dustinblanchard avatar Feb 23 '24 15:02 dustinblanchard

Django 5 has been out for about 4 months now and Elasticsearch 8.x has been out for over 13 months. I've tried installing Haystack from master and it's pretty bad.

There's no backend support for Elasticsearch 8.

The Elasticsearch 7 backend might be working, but I get non-stop SSL/TLS errors from urllib3 with self-signed certs. The fix that worked with previous versions mentioned in #1678 no longer works and appears to be due to the python elasticsearch library changing...but there doesn't appear to be a way to influence certificate handling in django-haystack backends. I basically have to pin elasticsearch to 7.17.9 and urllib3 to 1.26.18. If I install the latest versions, nothing works.

darkpixel avatar Apr 03 '24 17:04 darkpixel

Hi, I'd like to help get this done since this is the last package blocking our upgrade to Django 5.0 and Python 3.12... and I'm wondering what's the best place to start with and how to contribute.

I figured #1917 or #1921 would be the places to start, but I see the unresolved merge conflicts are mostly about which versions of Python & Django to support going forward where I as an outsider don't feel like a worthy judge to pick what's best...

#1921 sets the CI to test for Django 4.1 and python 3.11 only. While master currently tests for Django 3.2, 4.2 and 5.0, but only on Python 3.8 and 3.9. We're currently using django-haystack 3.2.1 with whoosh and Django 4.2 and Python 3.11 without issues and plan to upgrade to Django 5.0 and Python 3.12 and neither of those combinations are currently tested in either master or #1921.

I'm willing to look at the tests and failing CI, but I need to know which versions of Django and Python I should focus on and I feel like that's a decision that should be made by the project's maintainer, but I'm not even sure who the current maintainer is.

(pinging @acdha @cclauss as you seem to be the most active people concerning these issues)

black3r avatar Apr 25 '24 20:04 black3r

It would be great to have your help on this.

The three pinned issues at the top of our issues page are meant to be solved from left to right.

  • https://github.com/django-haystack/django-haystack/issues
    • #1917
    • #1924
    • #1863

cclauss avatar Apr 26 '24 05:04 cclauss