djangocms-text-ckeditor icon indicating copy to clipboard operation
djangocms-text-ckeditor copied to clipboard

Fix update notification on latest foss version of ckeditor 4.22.*.

Open corentinbettiol opened this issue 1 year ago • 3 comments

Hi. Ckeditor started to show a notification yesterday: image

It's a problem because it shows on every ckeditor box, even the ones who are part of a form on a public-facing website: every visitor of the site will see this.

image

Since we can't use versions 4.23+ (those are lts versions, which needs a license key to work, they changed the license), what we can do as a temporary fix is simply remove the notification process on the ckeditor code (gnu gpl3, we're allowed to make changes to the program).

corentinbettiol avatar Feb 08 '24 08:02 corentinbettiol

https://github.com/django-ckeditor/django-ckeditor/commit/d1cd092b4fbfb0534ded7f09a219d89fea5e547f Here's a different fix. All you have to do is versionCheck:false in the configuration. That being said, 4.22.1 is already known to be insecure, therefore hiding the notification isn't really fixing anything.

matthiask avatar Feb 12 '24 21:02 matthiask

@matthiask Thank you very much for the hint!! I like the system check warning.

fsbraun avatar Feb 12 '24 21:02 fsbraun

Thank you for this fix @matthiask!

corentinbettiol avatar Feb 13 '24 07:02 corentinbettiol

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 13 '24 18:05 stale[bot]

This will now be closed due to inactivity, but feel free to reopen it.

stale[bot] avatar Jun 10 '24 19:06 stale[bot]