djangocms-admin-style icon indicating copy to clipboard operation
djangocms-admin-style copied to clipboard

fix: history summary

Open raffaellasuardini opened this issue 1 year ago • 1 comments

Description

As mentioned in the issue, the left padding in the page history has been updated.

Before:
#change-history .paginator,.change-list table .paginator,.dashboard table .paginator,.results table .paginator,.tabular table .paginator {
    box-shadow: none!important;
}

After:

#change-history .paginator,.change-list table .paginator,.dashboard table .paginator,.results table .paginator,.tabular table .paginator {
    box-shadow: none!important;
    padding-left: 10px;
    box-sizing: border-box;
}
  • #516

raffaellasuardini avatar Feb 21 '24 16:02 raffaellasuardini

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (f1bbc9d) to head (721fc91).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #520   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           33        33           
  Branches         3         3           
=========================================
  Hits            33        33           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 21 '24 16:02 codecov[bot]

@raffaellasuardini Can you rebase your fork and make the change to the corresponding sass file? This is compile into the css. Only changes in the sass files will be persistent.

fsbraun avatar Mar 26 '24 17:03 fsbraun

Sure @fsbraun. I'm going to work on it.

raffaellasuardini avatar Mar 27 '24 15:03 raffaellasuardini

@raffaellasuardini Can you also run gulp sass to update the css assets?

fsbraun avatar Mar 29 '24 18:03 fsbraun

@fsbraun I ran the gulp file but it also created files like.eot .ttfand .woff should I also include them?

raffaellasuardini avatar Mar 29 '24 18:03 raffaellasuardini

Yes, please do that. Sometimes updates on the compiler lead to minor changes in the binaries.

fsbraun avatar Mar 29 '24 20:03 fsbraun