django-cms icon indicating copy to clipboard operation
django-cms copied to clipboard

fix: Set toolbar direction based on toolbar language

Open fsbraun opened this issue 1 year ago • 4 comments

Description

@sakhawy

This PR sets the toolbar text direction based on the toolbar language and not based on the document language.

This needs a "polyfill" to work with Chrome before 120 which is added at least in a basic version.

Related resources

  • #...
  • #...

Checklist

  • [ ] I have opened this pull request against develop-4
  • [ ] I have added or modified the tests when changing logic
  • [ ] I have followed the conventional commits guidelines to add meaningful information into the changelog
  • [ ] I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

fsbraun avatar May 02 '24 14:05 fsbraun

The patch is minimal, though. We might find places with weird layout. I'll try to add a few more lines later.

fsbraun avatar May 02 '24 15:05 fsbraun

Alright, I'll do some manual tests later!

sakhawy avatar May 02 '24 15:05 sakhawy

@sakhawy So, the polyfill should be complete ;-)

fsbraun avatar May 02 '24 18:05 fsbraun

Once, we have this merged, I'll chery-pick it into #7901

fsbraun avatar May 02 '24 18:05 fsbraun

@sakhawy Can you give this a final check, so we can merge it. I would love to backport it to 3.11 and include it in 3.11.6 which I am about to release...

fsbraun avatar May 05 '24 12:05 fsbraun

Well spotted, thank you!

fsbraun avatar May 11 '24 17:05 fsbraun

@sakhawy Fixed both resize cursor and missing polyfill patch. If you're good to go, let me know by approving the PR :-)

fsbraun avatar May 12 '24 06:05 fsbraun