django-cms
django-cms copied to clipboard
Fix 5930 page attribute as varname
Description
It adds the same behaviour to templatetag {% page_attribute 'field_name' 'page_lookup' as varname %}
as is already implemented in templatetag {% page_url 'page_lookup' as varname %}
. If settings.DEBUG = True
and the underlying page is missing, the templatetag fails silently instead of raising a template exception.
This pull request superseeds #6602 and has been rebased against version 3.8.0.
Related resources
- #5930
- #6602
Checklist
- [x] I have opened this pull request against
releases/3.8
- [x] I have updated the CHANGELOG.rst
- [x] I have added or modified the tests when changing logic
Can we rebase this against develop maybe?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@jrief looks like this got lost in time. Is it still relevant? If so perhaps you could retarget at develop
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This will now be closed due to inactivity, but feel free to reopen it.