Toolbar issues
Summary
get_item_count
Expected
cms.toolbar.toolbar.CMSToolbar and cms.toolbar.items.Menu inherit from cms.toolbar.items.ToolbarMixin.
The methods they inherit should work consistently in the subclasses.
Actual
The CMSToolbar.get_item_count method always returns 0 items (because Toolbar.items always seems to be []).
Menu.get_item_count however works as expected.
get_menu
Expected
cms.toolbar.items.Menu.get_menu should return a sub-menu, just as cms.toolbar.toolbar.CMSToolbar.get_menu returns a menu.
Actual
cms.toolbar.items.Menu.get_menu does not exist, meaning you can't find a sub-menu.
find_items and Menu
Expected
self.toolbar.find_items() should work consistently for all item types.
Actual
A self.toolbar.find_items(Menu) causes an error:
ValueError
<Menu:Language> is not in list
The error is raised in results.append(ItemSearchResult(candidate, self._item_position(candidate))), when it tries to handle the Language menu object.
Environment
- django CMS version: 3.5.2