angular2-smart-table icon indicating copy to clipboard operation
angular2-smart-table copied to clipboard

[SUGGESTION] Rename Settings class to a less generic name

Open joaoa-casagrande opened this issue 10 months ago • 1 comments

In this example:

settings: Settings = {
  columns: {
    id: {
      title: 'ID'
    },
    name: {
      title: 'Full Name'
    },
    username: {
      title: 'User Name'
    },
    email: {
      title: 'Email'
    }
  }
};

The type of the settings property is called Settings, and with today's IDEs (like WebStorm), automatic import is a very handy feature. So when a class has a common name, like Config or Settings instead of something more specific like Angular2SmartConfig or Angular2SmartSettings, it' becomes a hassle to import bacuse the IDE may import the wrong. So maybe changing it to something more specific to this package may be better in the future

joaoa-casagrande avatar Dec 21 '24 21:12 joaoa-casagrande