std icon indicating copy to clipboard operation
std copied to clipboard

incompatible with pending Nix changes

Open nrdxp opened this issue 3 years ago • 9 comments

Running with nixos/nix#6530, which is currently planned for the next point release, I am getting the following eval error pretty much everywhere in a work project:

error: evaluation aborted with the following error message: '

       Everything under ${cellsFrom}/* is considered a Cell

       Cells are directories by convention and therefore
       only directories are allowed at ${cellsFrom}/*

       Please remove '${cellsFrom}/std' and don't forget to add the change to version control.
       '

Not sure the root cause yet. Will post back when I know more

nrdxp avatar Jun 03 '22 22:06 nrdxp

okay, so with the follow diff:

diff --git a/src/grow.nix b/src/grow.nix
index 1116a3b..a4a5726 100644
--- a/src/grow.nix
+++ b/src/grow.nix
@@ -86,7 +86,7 @@
     # Validations ...
     Organelles = validate.Organelles organelles;
     Systems = validate.Systems systems;
-    Cells = l.mapAttrsToList (validate.Cell cellsFrom Organelles) (l.readDir cellsFrom);
+    Cells = l.mapAttrsToList (validate.Cell cellsFrom Organelles) (l.traceVal (l.readDir cellsFrom));
 
     # Helpers ...
     accumulate =

It seems the type of cells/std is no longer known at this stage:

trace: { std = "unknown"; }

Probably because of the new virtual filesystem. I would imagine an unknown value in a builtin function is undesirable and should be worked out before the change is merged, so maybe it won't affect us by that time?

nrdxp avatar Jun 04 '22 00:06 nrdxp

@nrdxp Is this issue still warranted or should we revive mitigation efforts in any way?

blaggacao avatar Sep 07 '22 19:09 blaggacao

Well the lazy-trees branch still hasn't been merged: NixOS/nix#6530

I guess we'll have to wait and see what this looks like after it is merged, as it is a pretty fast moving target.

nrdxp avatar Sep 07 '22 20:09 nrdxp

  • Is this still true?

  • What can we do ahead of time?

blaggacao avatar Dec 18 '22 20:12 blaggacao

  • Last I checked yes. The lazy-trees branch seems to break a lot of flakes for me, to the point I haven't been able to test it much
  • We can try to work out the breakage, but the lazy-tree branch still has changes coming in, so perhaps we should wait til it is at least out of draft

nrdxp avatar Dec 19 '22 14:12 nrdxp

changes coming in

changes yes, but maybe not breakages, any more? I'd like the idea to start thinking in forward-compatibility, here.

blaggacao avatar Dec 19 '22 20:12 blaggacao

Yeah but as I said, it breaks a lot of stuff so it's kinda hard to test and pretty intimidating to start to fix. Feel free anytime though :sweat_smile:

nrdxp avatar Dec 19 '22 22:12 nrdxp

Looks like the lazy-trees branch is finally out of draft, so it may be just the time to give it another shot.

nrdxp avatar Dec 20 '22 18:12 nrdxp

These nix changes are pending and pending :hourglass: :smile:

blaggacao avatar Jul 13 '23 22:07 blaggacao