divio-cli icon indicating copy to clipboard operation
divio-cli copied to clipboard

Fix bash syntax error on divio project pull db

Open ajhalili2006 opened this issue 4 years ago • 1 comments

Fixes https://github.com/divio/divio-cli/issues/240

I'm currently testing this on an Ubuntu 20.04.2 Dell computer with Python 3.8 (not sure) and pip 20.x (will update later)

ajhalili2006 avatar Mar 03 '21 17:03 ajhalili2006

Hey, thank you for your contribution! I have a question about the change. I think the quotes around 'db' should collide with the outer quotes ' around the SQL statement. Could you quote the SQL with " instead? In addition, we try to keep everything below 80 chars in line length where possible and this command can be broken down below 80 chars. Do you have a reason for making it all into one line?

Cheers

kinkerl avatar Oct 11 '21 09:10 kinkerl

Closing due to inactivity.

derlin avatar Aug 28 '23 12:08 derlin