Akash comments

Results 30 comments of


                                            Akash

Improve PEcAn.SIPNET package/model documentation and connect PEcAn.SIPNET README to PEcAn book

Hi @Eshaan-byte! Thanks for your interest and for taking the time to review the documentation thorough, approach looks solid. I am assigning this to you now. Feel free to open...

Refactor README.md to align with notebook workflow and fix outdated content

Thanks for the heads up @AritraDey-Dev ; here i would strongly lean toward not creating equal sections for web + notebook in README, since the web ui is deprecated. instead...

Deprecate gSSURGO.Query

Thanks for your interest @Shivang14d04, start by reviewing the current function and its associated tests and feel free to open a PR when you're ready

Refactor Settings handling in soilgrids_ic_process()

the link you opening seems to be to the web UI it's for running PEcAn workflows, so it won’t automatically reflect your code changes. I wouldn’t recommend you to go...

Replace manual unit conversions to consistently use `ud_convert()` helper function

Thanks for your interest @ayushman1210! You are welcome to pick this up

Replace stateful samples.Rdata logging with structured manifest file (runs_manifest.csv)

That makes sense, relying on string construction logic 'post hoc' does create a hidden dependency on the folder naming convention, and as you said which creates debt if we ever...

Replace stateful samples.Rdata logging with structured manifest file (runs_manifest.csv)

Thanks!, I have updated the issue

Deprecate gSSURGO.Query() #3697

Just regenerate the docs using `devtools::document("modules/data.land") ` This will auto-generate `modules/data.land/man/gSSURGO.Query.Rd` , no need to edit it manually since it's produced from the roxygen comments. After regeneration commit the updated...

Make `BADM_IC_process()` use PEcAn Settings / MultiSettings consistently

@shivpratikhande that could be an another refectory of `soilgrids_ic_process()` i need to take a look. but the issue says a different function; I apologize to pointing to wrong file `modules/data.land/R/IC_SOILGRID_Utilities.R`...

Make `BADM_IC_process()` use PEcAn Settings / MultiSettings consistently

apologize i missed track on this; does still anyone wanna work on this ?