Divij Vaidya

Results 75 comments of Divij Vaidya

@ijuma I have addressed your comments. Please review when you get a chance.

@C0urante I won't be able to pick this up until 16th Oct. If no one has picked this up my then, I would happily pick it up. A problem that...

@mimaison perhaps you might be interested in looking at this one? I have done an initial review.

@ijuma, would like to take a look at this or perhaps tag a committer who would be most suited to look into this one? (note that we can review this...

Hi @phongtatyaemsomphong Please send an email to the user mailing list for your question. You can find the mailing list at https://kafka.apache.org/contact.html Pull requests such as this are used to...

Thank you for the review. Looks good. One question though (which does not have to be addressed part of this PR), do we have a linter for scala that can...

Thank you for the code change @nikita15p. Could we add a unit test here which fails prior to this change and passes after? It would help us catch any regression...

Let me get to a first review by end of this week @simonz-bq . Meanwhile, it would be great if we could get some testing around the edge cases that...

The existing code does not release in a `finally` block because we want to release the buffer as soon as possible to reclaim memory sooner rather than at the end....

@ijuma what are your thoughts on this one? I would either like to discard it or have it merged since it is pending for a long time! Let me know...