Divij Vaidya

icon indicating an email [email protected]

icon company @aws icon location Berlin, Germany icon location PMC member/Committer @ Apache Kafka & Apache TinkerPop | Software Engineer @ Amazon

Results 75 comments of Divij Vaidya

MINOR: Include the inner exception stack trace when re-throwing an exception

@ijuma I have addressed your comments. This is ready for your review (pending test run).

MINOR: Include the inner exception stack trace when re-throwing an exception

@tombentley requesting code review bandwidth from you here. We already have 3 non-committer approvals on this one.

MINOR: Include the inner exception stack trace when re-throwing an exception

Rebased with the latest `trunk` to resolve merge conflicts.

MINOR: Catch InvocationTargetException explicitly and propagate underlying cause

@dengziming @showuon please review this small change.

MINOR: Catch InvocationTargetException explicitly and propagate underlying cause

@mimaison kindly review when you get a chance.

MINOR: Catch InvocationTargetException explicitly and propagate underlying cause

@showuon requesting for your code review time on this one. We already have two approvals from non-committers.

MINOR: Catch InvocationTargetException explicitly and propagate underlying cause

The failing tests for JDK 11 are unrelated to the code changes. ``` Build / JDK 11 and Scala 2.13 / testLargeAssignmentAndGroupWithNonEqualSubscription() – org.apache.kafka.clients.consumer.StickyAssignorTest 1m 3s Build / JDK 11...

KAFKA-13036: Replace EasyMock and PowerMock with Mockito for RocksDBMetricsRecorderTest

@ableegoldman @cadonna please help review this test in the `streams` domain.

KAFKA-13036: Replace EasyMock and PowerMock with Mockito for RocksDBMetricsRecorderTest

@dplavcic Thank you for your review and enlightening me on better usage of Mockito. I have addressed your comments. Please take another look when you get a chance.

KAFKA-13036: Replace EasyMock and PowerMock with Mockito for RocksDBMetricsRecorderTest

@dplavcic I have added the test coverage report to the description of this ticket. This revision is ready for your review now. Thanks again for your patience and spending time...