FluidLite icon indicating copy to clipboard operation
FluidLite copied to clipboard

[Suggeston] Replace libvorbis with stb_vorbis

Open RyanBram opened this issue 8 years ago • 5 comments

One of the goal of FluidLite is to become a lightweight replacement for Fluidsynth. As vorbis format is only needed for sf3 support, using libvorbis+libogg as additional library will make FluidLite become heavier. By replacing libvorbis with stb_vorbis it will get benefits such as:

  1. stb_vorbis is more lightweight than libvorbis;
  2. stb_vorbis has lesser dependencies than libvorbis (it only need itself without libogg);
  3. stb_vorbis is licensed under public domain.

I don't have any programming skills so I am really sorry if I cannot help much other than giving suggestion.

Best regards, RyanBram

Link https://nothings.org/stb_vorbis/ https://github.com/nothings/stb

RyanBram avatar Mar 04 '17 13:03 RyanBram

Might make sense to make SF3 support totally optional so vorbis isn't required at all? Then there will be zero deps?

MrSapps avatar Apr 13 '17 19:04 MrSapps

I don't know. There is a good chance that a given project who would benefit from fluidsynth->fluidlite is already dealing with audio in various formats, and as such probably already needs libvorbis/libogg.

hanetzer avatar May 20 '17 07:05 hanetzer

I think so too, which is why having it completely optional would be the nicest option IMO.

MrSapps avatar May 20 '17 23:05 MrSapps

I added support for stb_vorbis in my fork. Also #17 is fixed.

katyo avatar Feb 06 '20 08:02 katyo

Because my PR was merged, can we close this issue?

katyo avatar Jun 14 '20 16:06 katyo