sphinxcontrib.asciinema icon indicating copy to clipboard operation
sphinxcontrib.asciinema copied to clipboard

Published 20 hours ago • verified publisher icon divi255

Self hosted, wrong (fixed) player JS location

Open alperyazar opened this issue 6 months ago • 7 comments

Hi,

https://github.com/divi255/sphinxcontrib.asciinema/blob/f1882d400c08a264c920973511acab2bfc504f72/sphinxcontrib/asciinema/asciinema.py#L40

I think, this commit assumes that the position of the page with asciinema directive is fixed to _static directory. This assumption makes many pages broken.

It looks like the previous version is fine: https://github.com/divi255/sphinxcontrib.asciinema/blob/75a71688118f4ca4f67c3faea673e7f686b72b74/sphinxcontrib/asciinema/asciinema.py#L25

.css file is included correctly thanks to: https://github.com/divi255/sphinxcontrib.asciinema/blob/f1882d400c08a264c920973511acab2bfc504f72/sphinxcontrib/asciinema/asciinema.py#L12

Thanks!

alperyazar avatar Jan 27 '24 13:01 alperyazar