connect-mongostore icon indicating copy to clipboard operation
connect-mongostore copied to clipboard

Updating the url parse function to support replica sets using the Mongodb parsing function and some mapping logic

Open seanmwalker opened this issue 9 years ago • 2 comments

This function now gets a well parsed url based on the parse function that MongoDb uses. Then this function maps the parsed data into an options structure that matches what this module was expecting.

We've added an early version of the changes to this module to our local repository under a different name to keep moving forward, but I wanted to see if I could contribute back to this module. If this pull request is accepted we'll change over to using the published version here. Let me know if you have any questions or concerns. Thanks!

seanmwalker avatar Oct 17 '14 22:10 seanmwalker

Nicely done! I'll review the PR shortly. In the meantime, I actually have a branch here that attempts the same, I presume, thing - switch to use MongoClient and clean up interface (hence the breaking change and v1.0.0).

diversario avatar Oct 21 '14 02:10 diversario

Your new branch looks really good. I wanted to go that route, but didn't want to break the existing api. I'm sure we'll change over to 1.0.0 when that's out. Till then if there is anything we can change about this PR or another approach, it'd be great. Let me know, I have some bandwidth to do the work.

seanmwalker avatar Oct 21 '14 02:10 seanmwalker