proshop_django
proshop_django copied to clipboard
divanov11
Reset productDetails before request
Hey Dennis I really enjoyed your Udemy course!
I found a minor bug which is about ProductScreen component.
To explain how to see the bug,
- At the first time you click product from the HomeScreen, <Loader /> works just fine in ProductScreen component, but from the second times, it doesn't work anymore.
- If you go back and choose other items, somehow doesn't work, and it also shows previous item infos for a short time(which bothers me).
This PR will fix the bug. cheers!
Sanghyuk from Korea.
Yes same thing happens with me
On Fri, 14 May 2021, 2:35 pm Sanghyuk Jeong, @.***> wrote:
Hey Dennis I really enjoyed your Udemy course!
I found a minor bug which is about ProductScreen component.
To explain how to see the bug,
- At the first time you click product from the HomeScreen, works just fine in ProductScreen component, but from the second times, it doesn't work anymore.
- If you go back and choose other items, somehow doesn't work, and it also shows previous item infos for a short time(which bothers me).
This PR will fix the bug. cheers!
Sanghyuk from Korea.
You can view, comment on, or merge this pull request online at:
https://github.com/divanov11/proshop_django/pull/10 Commit Summary
- Reset productDetails before request
File Changes
- M frontend/src/actions/productActions.js https://github.com/divanov11/proshop_django/pull/10/files#diff-8bfc6d95272f3175c49db7886c7e0f68e1fd61030ce9a1c59bbb09e6df374e2a (2)
- M frontend/src/constants/productConstants.js https://github.com/divanov11/proshop_django/pull/10/files#diff-dd57fb27dca01b9c713c1ccbdc7c023b37fa8a3f4eaded59bf1ddc085b9e8f98 (1)
- M frontend/src/reducers/productReducers.js https://github.com/divanov11/proshop_django/pull/10/files#diff-761d3d1b00b7e97b694e10cbe943edd1ecf83522cdd92207336e9f1fa0d315f5 (4)
Patch Links:
- https://github.com/divanov11/proshop_django/pull/10.patch
- https://github.com/divanov11/proshop_django/pull/10.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/divanov11/proshop_django/pull/10, or unsubscribe https://github.com/notifications/unsubscribe-auth/APNBYSOZLIEVR7WJ325INH3TNTRWHANCNFSM444CCZXQ .
@mrcaption49 These three changes fixed the bug :) hopefully it will work on yours too