mumbleapi icon indicating copy to clipboard operation
mumbleapi copied to clipboard

setup editor config, flake8 and isort

Open itzomen opened this issue 3 years ago • 6 comments

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

  • Want to add a basic .editorconfig file
  • Next, we’ll add flake8 to enforce PEP8 rules
  • Finally, isort to have a standard way of sorting imports

Additional context

Well, the main aim is to maintain style consistency in the project as it grows.

itzomen avatar May 12 '21 02:05 itzomen

Hey @itzomen Thanks for your suggestion! How do you want flake8 styling to work? Usually, it goes by every branch merge. Are you thinking of something else?

abhivemp avatar May 12 '21 09:05 abhivemp

Hey @itzomen Thanks for your suggestion! How do you want flake8 styling to work? Usually, it goes by every branch merge. Are you thinking of something else?

Well, wanna just setup the basic for code linting so the code base follows pep8 rules

itzomen avatar May 12 '21 16:05 itzomen

Hey, if this is not started I can pick this up. Thanks!

M-krishna avatar May 15 '21 05:05 M-krishna

@M-krishna it's already been implemented. We aren't pushing this patch yet because this is a post-MVP feature

abhivemp avatar May 15 '21 07:05 abhivemp

@M-krishna it's already been implemented. We aren't pushing this patch yet because this is a post-MVP feature

Cool then!

M-krishna avatar May 15 '21 07:05 M-krishna

@itzomen I am going to open your PR. Let's it is corporate this feature because it's the least we can do to clean up the codebase. Update your branch accordingly and tag me when you are done. I'll reciew and merge.

abhivemp avatar May 16 '21 08:05 abhivemp