diffusionbee-stable-diffusion-ui icon indicating copy to clipboard operation
diffusionbee-stable-diffusion-ui copied to clipboard

Add Electron linter to GitHub Actions

Open Leland opened this issue 3 years ago • 2 comments

Runs npm run lint on each PR and merge to master. This will run a set of Vue eslint rules against the code, preventing common sense errors from getting merged.

The build executes in seconds, example job here: https://github.com/Leland/diffusionbee-stable-diffusion-ui/actions/runs/3169819178

This PR also fixes the existing errors. All have to do with unused arguments, unused variables, and mixing tabs and spaces.

Finally, this PR introduces an .editorconfig file that standardizes the spacing and line ending usage across the repo, and removes all instances of tabbed indents in the electron-app folder.

My hope is this template will spur contributors to add additional actions. It would be great to get a build action created, as well as integration tests around the app.

Leland avatar Oct 02 '22 19:10 Leland

@divamgupta any interest in this one? It will help you catch if contributions in PRs have obvious problems

Leland avatar Oct 06 '22 02:10 Leland

@divamgupta starting to get conflicts in this due to age :) Do you have any interest in merging this workflow?

Leland avatar Oct 14 '22 12:10 Leland

Hey, thanks for the PR, once the development is in a stable state, we can def add liners, actions and stuff.

divamgupta avatar Oct 31 '22 04:10 divamgupta

Fair enough :) (I think this is more helpful while development is not in a stable state, though)

Leland avatar Oct 31 '22 14:10 Leland