David Iglesias

Results 417 comments of David Iglesias

Thanks for the contribution! Please add a test for this case! This test is probably going to break: * https://github.com/flutter/packages/blob/main/packages/video_player/video_player_web/example/integration_test/video_player_test.dart#L43-L58

Duplicate of https://github.com/flutter/packages/pull/7828 Can you please collaborate with @tbansod2018 to get this landed in a single PR?

> Do I need to update the CHANGELOG.md for this change, or is it exempt from versioning? You do need to update the pubspec and CHANGELOG version, since this is...

Ah woops, we need a second reviewer! I'll find someone!

@slavap thanks for your message, feedback is always appreciated! (you should also be able to comment on the google doc itself if you want to!) To me, the biggest problem...

> So what would the default behavior and strategy be? @rayliverified The current implementation attempts to aggressively cache and pre-fetch the `assets` of your app; that will stop happening. The...

> So any short term feature losses that resolve the big issues deploying flutter web are welcome... as long as the vision for a sane default PWA experience is retained....

> App will serve old Image A (dolphin) to users until the cache expires. This is not entirely accurate. For those assets that get reuploaded and don't have versioning in...

> Can you be more specific about the intended usage without the service worker? I can't be more specific, because as you said, it depends on the capabilities of your...

> Note that the current waterfall (index.html -> flutter_bootstrap.js -> main.js) requires 3 round-trips! @jroitgrund You can inline your `flutter_bootstrap.js` into your `index.html`, and save one of those round trips....