dita-ot icon indicating copy to clipboard operation
dita-ot copied to clipboard

In PDF2: Select correct abbrev href target.

Open simtind opened this issue 3 years ago • 1 comments

Description

Select glossref instead of topicref as target when evaluating abbreviated-form gloss entries in pdf transformation.

Motivation and Context

Currently abbreviated-form gloss entriy references raises error DOTX060W as reported in #2773 and #3431. This issue seems to have been introduced in #3210. This PR does not revert the changes from #3210, but rather fixes the indexing so the correct href'd element is selected.

A more thorough fix discussed in #2773 and #3431 would be to update the pipeline to decorate the elements with separate ids so they can be correctly selected in the xsl transform.

How Has This Been Tested?

  • Tested on internal code base that manifested the issue.
  • Also tested on reproducer examples provided in the issue tickets. -- The initial example from #2773, abbreviation-test.zip did need to add print="yes" to the glossref in glossary.ditamap -- Otherwise, all examples built successfully with the patch, and failed with DOTX060W without it.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)

Documentation and Compatibility

None needed

Checklist

simtind avatar Jan 06 '22 09:01 simtind

This PR doesn't appear to have been merged and is waiting on someone to review. Can someone provide an update? We have writers asking to use abbreviated-form and I recalled seeing mention of problems here or in Slack.

kirkilj avatar Jul 07 '22 15:07 kirkilj

@kirkilj, @simtind - I apologize, I did not see this PR when I submitted #4002 (which is a similar fix, although a bit more robust). The original issue should be fixed in DITA-OT 3.7.4 and this PR can be closed.

However, the testcase revealed a second issue, which I filed #4026 for.

chrispy-snps avatar Oct 24 '22 23:10 chrispy-snps