dita-ot icon indicating copy to clipboard operation
dita-ot copied to clipboard

Flagging does not work when profiling attribute is set on topicref

Open raducoravu opened this issue 7 years ago • 10 comments

I tested this with DITA OT 2.5.2 but it's probably always been this way. If I have a DITAVAL looking like this:

 <val>
     <prop att="audience" val="internal" action="flag" color="purple" backcolor="green"/>
  </val>

and in the DITA Map I have a topicref:

   <topicref href="topics/introduction.dita" audience="internal"/>

publishing to PDF or to HTML-based outputs will ignore the flagging information. Possibly the PDF flagging could be made to work easier.

raducoravu avatar Oct 10 '17 12:10 raducoravu

Does this work with develop code?

jelovirt avatar Oct 13 '17 12:10 jelovirt

With 'develop' code, for the XHTML output the table of contents contains highlighted to entire subtree of topicrefs under the flagged topicref. Maybe somehow I expected that the actual topic content would have that color applied to it... For the PDF output neither table of contents not actual topic content reflect the flagging conditions.

raducoravu avatar Oct 16 '17 07:10 raducoravu

👍 Another client wanted flagging to work at topicref level: https://www.oxygenxml.com/forum/post44639.html#p44634

raducoravu avatar Nov 09 '17 13:11 raducoravu

We've had need for this feature as well in the past. Especially when a singular map covers multiple products and we need to review things with various engineering teams. It's nice to see the flagging on whole topics.

wbrisett avatar Apr 10 '18 18:04 wbrisett

This issue has been automatically marked as stale because it has not been updated recently. It will be closed soon if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 09 '20 19:04 stale[bot]

👍 Another one of our users who uses profiling attributes on topicrefs and expects the flagging to be propagated inside topics for PDF and EPUB outputs: https://www.oxygenxml.com/forum/viewtopic.php?p=63320#p63320

Where we have applied a product attribute to a topicref, we would like to include it in the output, but with the colour defined in the ditaval....
 As an alternative, I tried applying the product attribute to the <body> element, but that doesn't appear to work.
I have found that we can achieve the required results by applying the product attribute to a child element of the topic body, even if the topicref has the same product attribute.

raducoravu avatar Sep 03 '21 06:09 raducoravu

We at Infineon face the same problem for mapref elements and PDF output, the content is not flagged as expected by the authors. A lot of content is referenced by keys, e.g. <mapref audience="Internal" keyref="content" />, which might also have an impact on this. This issue was re-tested with dita-ot 4.1.2. Is there any plan or chance that this is fixed or implemented?

skulle avatar Mar 13 '24 08:03 skulle

@skulle the latest DITA OT is 4.2.1. Have you tested with it? maybe you can create a small DITA project (map, couple of topics, ditaval file) exemplifying the problem and attach it to the issue, at least if someone manages to fix the issue at some point they have a sample to test their changes with.

raducoravu avatar Mar 13 '24 08:03 raducoravu

@raducoravu sure I can do this. Let me test this with the latest version as well. Also I am going to attach a sample.

skulle avatar Mar 13 '24 08:03 skulle

Dita-ot 4.2.1 has the same issue. Attached is a small sample, it uses a typical structure our authors use. sample.zip

skulle avatar Mar 13 '24 11:03 skulle