memefactory icon indicating copy to clipboard operation
memefactory copied to clipboard

bug/Memes passing challenge still marked as Stank in Resolved Challenges Tab

Open pmr212 opened this issue 4 years ago • 2 comments

User Story

As a user I want memes that receive more dank votes than stank to NOT be marked as stank in the resolved challenges tab.

Description

Type: Bug

Summary: Submitted meme from account 1. Challenged meme from account 2. Voted 3 Dank from account 1. Voted 2 Stank from account 2.

Meme entered Registry, which was expected. However it has "Stank" banner in resolved challenges tab. Upon further observation, all memes have "Stank" banner in resolved challenges tab.

Expected behavior

Dank memes should not have "Stank" banner

Actual behavior

"Stank" banner is on every meme, including Dank ones.

Reproduction

  • Open webapp
  • Submit meme
  • Challenge meme
  • Vote more dank than stank
  • Observe Resolved Challenges tab

Solution

Summary:

  • [ ] Make sure Dank memes are not marked Stank

Additional Information

History of particular meme - https://ropsten.etherscan.io/token/0xeda9bf9199fab6790f43ee21cdce048781f58302?a=0x116f1b759026244afbebce3680ca96ddee4e58be

  • browser console logs: ... comment: # (browser version)
  • Browser: Chrome

Logs

...

pmr212 avatar Dec 18 '19 18:12 pmr212

This is affecting mainnet (production) only or also QA instance?

fbielejec avatar Dec 18 '19 18:12 fbielejec

Both QA and mainnet

pmr212 avatar Dec 18 '19 18:12 pmr212