Nico Hoffmann ෴.
Nico Hoffmann ෴.
Indeed it is. So I am thinking to actually move the `Upload::chunk()` call here: https://github.com/getkirby/kirby/blob/main/src/Api/Api.php#L697 So any place using `$api->upload()` would work with it. Furthermore, I think I would like...
Yes, exactly. Have a version working locally. It really helps breaking this up but also having it all in the one class then. Now only need to add unit tests...
I think I have encountered an issue: Uploading a large file and canceling while it's uploading, it still shows up in the file list after a reload.
Turns out: When one cancels the upload dialog, all running uploads still run and finish in the background. This is not new in this PR but a lot more visible/likely...
@bastianallgeier I moved the `version` from its own named argument into the new `info` named argument. Felt more consistent as otherwise we might would want to add all info entries...
Yea I really get that. I opted against it in the PR because I think it makes the whole setup a bit easier/consistent if not one of the info parts...
So all info values from composer json also as named arguments?
Ok. The optional info array we need anyways as this has been supported so far already, just as subentry of the `extends` array. So it's more about whether to have...
@lukasbestle @bastianallgeier now with additional `version` arg
@psntr thanks got opening this new issue. I will try to take a closer look at this in the following days