Nico Hoffmann ෴.

Results 819 comments of Nico Hoffmann ෴.

Thank you! I think we do have all the info needed, will look more if we can find a bugfix somehow or if it's really just a nasty Safari bug...

@davidjablonski @bogdancondorachi has this been resolved for you with Apple's updates to Safari 16?

As your proposed solution would fundamentally break 100% of all existing websites, it's not really an option. In many cases, reading a file will also be much slower than checking...

@hdodov We have to agree to disagree here - breaking sites that drastically for 99% of the users also going to v4 is not something that we know our customers...

@hdodov could you please test if https://github.com/getkirby/kirby/commit/3f30e98ea85fdc6720d9aff7f9ea14f29abfce30 does improve performance for you at all? (or if you could share your setup/site for me to test, but I understand if that's...

Ok, might be even slower 😞 Before: After: Test: ```php $models = ['model-a', 'model-b', 'model-c', 'model-d', 'model-e', 'model-f']; Dir::make($this->tmp); foreach (range(1, 5000) as $i) { Dir::make($this->tmp . '/sub' . $i);...

I tried this (directly with `scandir()` and then some array intersect logic. As well as the glob attempt. But all didn't seem to be reliably better. But as @rasteiner pointed...

Testing with `clearstatcache()` between runs as suggested by @rasteiner: ### `main` branch: ### Alternative 1 ```php $models = array_keys(Page::$models); if (count($models) > 0) { $model = array_intersect($models, scandir($root))[0] ?? null;...

Maybe more apparent with 20 models ### `main` branch ### `scandir` intersect

https://github.com/getkirby/kirby/commit/50addd33a781af762953d02b27823ee59dde6de8