Nico Hoffmann ෴.
Nico Hoffmann ෴.
@bastianallgeier you're right, went with parsing the DOM - it's not an operation that we do a thousands of times, so I think the strictness here outweighs any potential performance...
@bastianallgeier First part finally done, I think the second part would be to return from `Page::permalink()` etc. a language-specific permalink for the current language when in multilang. Would you think...
Well, not quite. Cause the LinkField builds the URL itself.
@bastianallgeier To run it yourself, you need to copy the added performance tests from `bench/Filesystem` over to the `develop/minor` state. There run `composer run-script bench:baseline`. Then you can switch back...
@bastianallgeier I have reverted https://github.com/getkirby/kirby/pull/6218/commits/c903e6b192617645f2ffc9cdc3bf243a392821b0 again. With it, the performance was worse than `develop-minor`, particularly with no or one model: After reverting that change, this PR shows slight improvements over...
> Can't we also use if ($multilang === true) when fetching the language code? If it's false, we don't even need to load the app object. $languageCode can just always...
@lukasbestle could we switch our default generator to only use a lowercase alphabet?
@lukasbestle sounds to me like it would be an acceptable change for us. I'd suggest to make that switch not in 4.x but 5.0 though.
I don't see the immediate breaking change but it's a big enough change and there might be assumptions by users around the current format. That's why I'd rather play it...
@mrflix length has stayed the same, only all lowercased now.