Django 1.8 support (WITH admin module)

[bijanvakili]

This is a fix for Django 1.8 so that the AdminSite can work if the 'app_name' argument is no longer available.

This is also backwards compatible with Django <= 1.7

[craiglabenz]

Any reason this is yet unmerged?

[mattrobenolt]

Because we have no way to validate this. We don't run Django 1.8, so getting some to review and test this is a bit cumbersome. Sorry. :(

[craiglabenz]

Any way outsiders can help?

[Fluxx]

Any way outsiders can help?

Yes, if someone outside is willing to get a build matrix setup to test different versions of Django (and python) and add that, we'll be likely to accept it. At present Nexus has very little to no active usage inside Disqus so we don't have a ton of organization momentum to help maintain it. That's obviously not great news to hear but it's the reality of the situation.

[craiglabenz]

Fair enough. For now I've just forked, accepted that PR myself, and am moving forward. Appreciate that the lib even exists at all :)

[adamchainz]

#24 adds this plus tests in a build matrix with tox :smile:

[giftig]

Thanks @craiglabenz, I just ran into this issue while upgrading my django version to 1.8; I'll probably use your fork :+1:

[giftig]

Actually from what I can see, nexus 0.3.1 works fine with django 1.8; my problem now is with the gargoyle module. Is this pull request still needed? Upgrading from 0.3.0 to 0.3.1 of nexus fixed the issue described above for me.

[sssbox]

We ran into a few other issues with nexus and django 1.8. This is how we got it to work (including some changes from the pull requests in this conversation): https://github.com/disqus/nexus/compare/master...brilliant-org:master

Also, gargoyle needed a few small changes: https://github.com/disqus/gargoyle/compare/master...brilliant-org:master

[adamchainz]

Hey guys, you can install the YPlan branch which has tests and throws no warnings for us on Django 1.8 https://github.com/yplan/nexus/tree/yplan_django18 . We also have a gargoyle branch https://github.com/yplan/gargoyle/tree/yplan_django18

[craiglabenz]

Very cool @adamchainz -- great work!

[adamchainz]

You can now pip install nexus-yplan and gargoyle-yplan.

[giftig]

Cool, I'll give them a go; thanks.