disqus-react icon indicating copy to clipboard operation
disqus-react copied to clipboard

May `DiscussionEmbedConfig` type need `remoteAuthS3` field?

Open coiger opened this issue 2 years ago • 0 comments

Describe the bug

// https://github.com/disqus/disqus-react/blob/master/src/DiscussionEmbed.jsx#L81
getDisqusConfig(config) {
    return function () {
        ...
        this.page.remote_auth_s3 = config.remoteAuthS3;
        this.page.api_key = config.apiKey;
        ...
    };
}

In DiscussionEmbed components, it use remoteAuthS3 field in config props. However, there is no remoteAuthS3 field in DiscussionEmbedConfig => results: type error

  • See here to find DiscussiongEmbeConfig type definition.

To Reproduce

<DiscussionEmbed
  shortname='EXAMPLE'
  config={{
    ...
    remoteAuthS3: 'abcdefg....',
    apiKey: 'hijklmn...',
  }}
/>
  • If I pass config.remoteAuthS3 props to DiscussionEmbed component, typescript make error
    • there is no remoteAuthS3 in config props.

Expected behavior

  • DiscussionEmbed component may need remoteAuthS3 field in config props.
  • == DiscussionEmbedConfig type may need remoteAuthS3 field.

coiger avatar Nov 05 '23 12:11 coiger