disqus-react
disqus-react copied to clipboard
May `DiscussionEmbedConfig` type need `remoteAuthS3` field?
Describe the bug
// https://github.com/disqus/disqus-react/blob/master/src/DiscussionEmbed.jsx#L81
getDisqusConfig(config) {
return function () {
...
this.page.remote_auth_s3 = config.remoteAuthS3;
this.page.api_key = config.apiKey;
...
};
}
In DiscussionEmbed components, it use remoteAuthS3 field in config props.
However, there is no remoteAuthS3 field in DiscussionEmbedConfig => results: type error
- See here to find
DiscussiongEmbeConfigtype definition.
To Reproduce
<DiscussionEmbed
shortname='EXAMPLE'
config={{
...
remoteAuthS3: 'abcdefg....',
apiKey: 'hijklmn...',
}}
/>
- If I pass config.remoteAuthS3 props to
DiscussionEmbedcomponent, typescript make error- there is no
remoteAuthS3inconfigprops.
- there is no
Expected behavior
DiscussionEmbedcomponent may needremoteAuthS3field inconfigprops.- ==
DiscussionEmbedConfigtype may needremoteAuthS3field.