Marques Johansson

If CAPP is creating LBaaS instances (rather than just accessing them by a referenced/existing ID), then it is important for CAPP to cleanup after itself. Deletion of controller-created resources is...

This PR lacks any documentation on the new capabilities (ignoring the -emlb.yaml example). This is intentional to avoid usage until the remaining components of #693 can be incorporated.

/lgtm

> (how to know which VRF to add IP address reservations to ?) or will it create a new VRF altogether ?? With all of our IP options, IP Reservations,...

@rahulii `network_type` can be inferred from the `port` definitions. It may be redundant to offer it as a parameter. `port` definitions would need to include the network ports (everything that...

@rahulii this is a good observation. You are right that (a) for each VLAN defined there should be some IP definitions. The initial intent was to capture (b) IP reservations...

@rahulii correct. There is no state for IP assignments on the Equinix Metal API side. Management of which IP addresses are assigned to which nodes will need to be handled...

Here is how that is done in TF: * example: https://github.com/equinix/terraform-provider-equinix/blob/main/equinix/resource_metal_device_acc_test.go#L671 * field use: https://github.com/equinix/terraform-provider-equinix/blob/4825cd259b01bff64074cd1bdf78b6ad04f7a8cb/equinix/resource_metal_device.go#L518-L524

This work would benefit from a published Equinix Metal LoadBalancer SDK for Go. The one that was included in #454 is autogenerated and has been kept in internal/ to prevent...

@ndaa-skydance-animation-madrid thanks for opening the detailed issue. From your description and plan output, it looks like this is more of an annoyance and inaccurate handling of TF state rather than...