coroutine icon indicating copy to clipboard operation
coroutine copied to clipboard

compiler: resolve panic in substituteTypeArgs Function for `*ast.IndexListExpr`

Open iamrajiv opened this issue 1 year ago • 2 comments

Fixes: #141

This PR addresses a panic occurring in the substituteTypeArgs function within the types.go file. The panic is caused by the lack of handling for the *ast.IndexListExpr type, resulting in unexpected behavior during type substitution.

iamrajiv avatar Feb 11 '24 02:02 iamrajiv

I don't think @achille-roussel that we need a test for this because there are other cases in substituteTypeArgs for which tests were not added, so I'll just follow the same approach of not adding tests. But if you want, I can write a test for all the cases defined in the substituteTypeArgs function.

iamrajiv avatar Feb 11 '24 22:02 iamrajiv

Also to follow up on this:

there are other cases in substituteTypeArgs for which tests were not added

The git history may look like that was the case, but it's missing context about in-person development that happened at the time the project was being bootstrapped before it was made public. In general, we have strong test coverage for the features we support, and we maintain a rigorous testing culture to ensure we can continue to provide a high quality solution over time 👍

achille-roussel avatar Feb 11 '24 22:02 achille-roussel

Fixed by https://github.com/dispatchrun/coroutine/pull/148

chriso avatar Jun 17 '24 04:06 chriso