weaver-test icon indicating copy to clipboard operation
weaver-test copied to clipboard

Attempt to have fatal errors lead to the test process ending

Open Baccata opened this issue 2 years ago • 3 comments

Attempt at addressing https://github.com/disneystreaming/weaver-test/issues/651

Just a quick POC to see whether something can be done.

Baccata avatar Apr 24 '23 11:04 Baccata

It seems to work fine when I run test, but in testOnly with just the weaver suite it still hangs. It can be cancelled with ctrl+C though.

kubukoz avatar Apr 24 '23 14:04 kubukoz

but in testOnly with just the weaver suite it still hangs. It can be cancelled with ctrl+C though.

How did you test, out of curiosity ?

Baccata avatar Apr 24 '23 15:04 Baccata

oof I thought I'd linked the full repro in the original ticket...

https://github.com/kubukoz/demos/tree/sbt-weaver-hang

  1. test (runs weaver, munit, scalatest)
  2. testOnly DemoTestWeaver

kubukoz avatar Apr 24 '23 15:04 kubukoz