smithy4s icon indicating copy to clipboard operation
smithy4s copied to clipboard

Tentative fix of the signature implementation

Open Baccata opened this issue 3 years ago • 4 comments

The sigv4 trait contains what seems to be the service-specific name that should be used during the signature of the request.

Baccata avatar Jan 20 '22 14:01 Baccata

Think we've got this implemented already? AWS seems to work fine

kubukoz avatar Oct 05 '22 22:10 kubukoz

I think it's still needed, in the sense that it's probably working fine by accident, because the sigv4 name is coincidentally the same as the endpoint prefix for most services

Baccata avatar Oct 06 '22 09:10 Baccata

Anyhow, we need parity tests with existing SDKs

Baccata avatar Oct 06 '22 09:10 Baccata

oh I see. yes that makes sense

kubukoz avatar Oct 06 '22 09:10 kubukoz