smithy4s icon indicating copy to clipboard operation
smithy4s copied to clipboard

Generate Scaladoc / deprecations

Open kubukoz opened this issue 3 years ago • 2 comments

Originally mentioned in https://github.com/disneystreaming/smithy4s/issues/245 : the @deprecated trait should generate a @deprecated annotation in the Scala code, and the @documentation / @externalDocumentation traits should result in some Scaladoc being generated.

kubukoz avatar Jun 03 '22 17:06 kubukoz

I wholefully agree with this

Baccata avatar Jun 12 '22 11:06 Baccata

Started some work on the deprecations part of this.

kubukoz avatar Nov 12 '22 02:11 kubukoz

This looks like "fun" good-first-issue. If my noobie questions aren't too much hassle, I'll gladly pick this up. https://github.com/disneystreaming/smithy4s/pull/599 should provide some tips on how to implement scaladoc in the codegen no?

I believe something like this:

  • Add a case classDocumentation which extends Hint to the IR
  • Then add a way to render scaladocs in Renderer

zetashift avatar Jan 13 '23 17:01 zetashift

This looks like "fun" good-first-issue. If my noobie questions aren't too much hassle, I'll gladly pick this up. #599 should provide some tips on how to implement scaladoc in the codegen no?

I believe something like this:

  • Add a case classDocumentation which extends Hint to the IR
  • Then add a way to render scaladocs in Renderer

I think you got that right! Good luck and don't hesitate to reach out here or on Discord if you need assistance

And thanks, really

daddykotex avatar Jan 13 '23 18:01 daddykotex

yeah, I think you can draw some inspiration from #599. I left some hints for working on codegen code here, might be useful for a good feedback loop: https://github.com/disneystreaming/smithy4s/issues/496#issuecomment-1312563839

I believe something like this:

that sounds about right

kubukoz avatar Jan 13 '23 18:01 kubukoz

Mostly closed in #731, with some new tickets spawned to further improve this. Thanks @zetashift!

kubukoz avatar Jan 30 '23 18:01 kubukoz