smithy4s icon indicating copy to clipboard operation
smithy4s copied to clipboard

feat: Add support for flexible defaults encoding

Open ghostbuster91 opened this issue 10 months ago • 3 comments

PR Checklist (not all items are relevant to all PRs)

  • [x] Added unit-tests (for runtime code)
  • [ ] ~Added bootstrapped code + smoke tests (when the rendering logic is modified)~ N/A
  • [ ] ~Added build-plugins integration tests (when reflection loading is required at codegen-time)~ N/A
  • [ ] ~Added alloy compliance tests (when simpleRestJson protocol behaviour is expanded/updated)~ N/A
  • [ ] ~Updated dynamic module to match generated-code behaviour~ N/A
  • [x] Added documentation
  • [x] Updated changelog

Refers to #1398

ghostbuster91 avatar Feb 20 '25 12:02 ghostbuster91

I am not happy about the implementation of SkipIfEmptyCollection so I am fine with dropping it at this stage to minimize the amount of changes, but wanted to showcase it in case you think that it is worth to have something like that.

ghostbuster91 avatar Feb 20 '25 12:02 ghostbuster91

A good start 👍

Baccata avatar Feb 21 '25 09:02 Baccata

@kubukoz wanna have a look?

ghostbuster91 avatar Feb 21 '25 18:02 ghostbuster91

Good work. Just a couple nitpicks (and also this : https://github.com/disneystreaming/smithy4s/pull/1652#discussion_r1971927935)

Baccata avatar Mar 12 '25 09:03 Baccata

@ghostbuster91 fyi if you said "Closes #1398" merging this would've closed the ticket, worth remembering in the future

kubukoz avatar Mar 21 '25 13:03 kubukoz