smithy4s icon indicating copy to clipboard operation
smithy4s copied to clipboard

Update sbt to 1.10

Open kubukoz opened this issue 1 year ago • 2 comments

Closes #1538.

PR Checklist (not all items are relevant to all PRs)

  • [ ] Added unit-tests (for runtime code)
  • [ ] Added bootstrapped code + smoke tests (when the rendering logic is modified)
  • [ ] Added build-plugins integration tests (when reflection loading is required at codegen-time)
  • [ ] Added alloy compliance tests (when simpleRestJson protocol behaviour is expanded/updated)
  • [ ] Updated dynamic module to match generated-code behaviour
  • [ ] Added documentation
  • [ ] Updated changelog

kubukoz avatar Sep 06 '24 12:09 kubukoz

I've bisected the header problem down to https://github.com/sbt/sbt/releases/v1.9.7, I suspect it's this change: https://github.com/sbt/sbt/pull/7404

the current state is that headerLicense is unset in most projects.

kubukoz avatar Sep 06 '24 15:09 kubukoz

Well let's either set it or disable the header plugin altogether on irrelevant projects

Baccata avatar Sep 10 '24 06:09 Baccata