smithy4s icon indicating copy to clipboard operation
smithy4s copied to clipboard

Broken link in 05-compliance-tests.md

Open meldmy opened this issue 1 year ago • 2 comments

Refer to this example to see how we did it for Weaver in this project.

Hi guys, I found a broken link in the documentation reference to the nonexistent test in the codebase: https://disneystreaming.github.io/smithy4s/docs/protocols/compliance-tests#testing-the-protocol

Here, I found you used @GITHUB_BRANCH_URL: https://github.com/disneystreaming/smithy4s/blob/da4b23a68e2d03be4ac310d2aaca8ba755e79315/modules/docs/markdown/03-protocols/05-compliance-tests.md?plain=1#L51

meldmy avatar Apr 05 '24 21:04 meldmy

Thanks for reporting!

I think the class is gone altogether, some of Weaver integration seems to live directly in https://github.com/disneystreaming/smithy4s/blob/series/0.18/modules/tests/src/smithy4s/tests/ProtocolComplianceSuite.scala

kubukoz avatar Apr 15 '24 16:04 kubukoz

@meldmy would you like to submit a fix? (targetting the 0.18 branch)

kubukoz avatar Apr 17 '24 14:04 kubukoz

@kubukoz Yes, sure. I've just pushed it here https://github.com/disneystreaming/smithy4s/pull/1509

meldmy avatar May 05 '24 13:05 meldmy