pg2k4j icon indicating copy to clipboard operation
pg2k4j copied to clipboard

Add tests with postgres 11

Open rkass opened this issue 5 years ago • 4 comments

This adds tests for compatibility with postgres 11. This was inspired by issue https://github.com/disneystreaming/pg2k4j/issues/27 but doesn't solve that issue. However, it does add some code that might allow @teej or others to reproduce that issue in an integration test.

rkass avatar Jul 05 '19 14:07 rkass

@markglh any ideas why this build is failing to pick up the GPG key?

rkass avatar Jul 10 '19 13:07 rkass

Hey @rkass - ahh yeah I've seen this before, it's this: https://docs.travis-ci.com/user/pull-requests/

Basically because it's from your own fork travis protects the encrypted vars for security, the way around it is to prevent that part of the build running for forks, so try replacing:

before_install:
  ## export GPG details
  - echo $GPG_SECRET_KEYS | base64 --decode | gpg --import

with

before_install:
  ## export GPG details
  - 'if [ "$TRAVIS_PULL_REQUEST" = "false" ]; then echo $GPG_SECRET_KEYS | base64 --decode | gpg --import; fi'

I can't push the change as it's on your fork :)

...It could technically fail if the deploy kicks off whilst on a PR, but that would be a bug anyway!

markglh avatar Jul 11 '19 01:07 markglh

looks like just test failures now

markglh avatar Sep 09 '19 08:09 markglh

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

:x: Ryan Kass
:x: markglh


Ryan Kass seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar May 03 '22 14:05 CLAassistant