Tim Disney

Results 108 comments of Tim Disney

That file should probably just be minified with sourcemaps (it's being generated by webpack).

I can repro it. The extension problem must have been recently introduced. I'll fix and add regression tests for that. The ambiguous scopesets error is surprising because I thought we...

I think the extension issue was introduced in https://github.com/sweet-js/sweet-core/commit/1087af322cb7589953e69dc40e2b636a059a89f5#diff-828804bf7ffcce021806a0fc90ea20f9 Defaulting to the empty array was the problem. The scopeset issue has been there since introducing recursive modules I think. I'll...

Haha, sorry about that, the docs say 1.0 but mean 1.0+. We should fix that.

What's the current status on the npm package?

Good idea! The codebase is definitely complex. I'd be holding off doing too much design documentation for a while since pieces were still in flux but I think most things...

This is an ASI bug with syntax created via the `from*` methods. The `yield` should be taking on the line number of the appropriate context but clearly it's not.

Your example is actually not a valid program because of ASI. It's actually getting parsed as: ``` js syntax fn = function (ctx) { let args = ctx.next().value; let body...

Looks like it's due to an old shift codegen bug: https://github.com/shapesecurity/shift-codegen-js/issues/33 More reason to update to the latest shift.

Ah good call. That's probably a better default.