disksing
disksing
the client uses some new API that were introduced after 5.0.0 (an example: https://github.com/tikv/client-go/issues/280) and we do not have any option to turn it off.
The requirement was first brought up in https://github.com/tikv/client-go/pull/239 I think we may need more discuss to decide if it is a generic requirement. /cc @neicunlideyu @iosmanthus
This issue was brought up from https://github.com/tikv/client-go/pull/253#issuecomment-886561270 We may continue discussing it here with comments /cc @jackysp @lysu
We need more examples to illustrate how to use `client-go`. - [x] basic txnkv - [x] basic rawkv - [ ] options usage - [x] run GC - [ ]...
https://github.com/tikv/client-go/pull/204/checks?check_run_id=2964207159 ``` suite.go:63: test panicked: runtime error: invalid memory address or nil pointer dereference goroutine 1363 [running]: runtime/debug.Stack(0xc000423590, 0x278bce0, 0x43b5110) /opt/hostedtoolcache/go/1.16.5/x64/src/runtime/debug/stack.go:24 +0xab github.com/stretchr/testify/suite.failOnPanic(0xc000188780) /home/runner/go/pkg/mod/github.com/stretchr/[email protected]/suite/suite.go:63 +0x6d panic(0x278bce0, 0x43b5110) /opt/hostedtoolcache/go/1.16.5/x64/src/runtime/panic.go:971 +0x499 integration_tests_test.(*testLockSuite).TestDeadlockReportWaitChain(0xc000833a40)...
In tests when we manually create a committer to test, `ttlManager.keepalive` goroutine may get leak. Currently, it is ignored in `integration_tests/main_test.go`.
There are test suites that create a new test store for each test case. It costs too much memory. Two obvious examples are `testCommitterSuite` and `testLockSuite` Mentioned in https://github.com/tikv/client-go/pull/155
Currently, we use global configuration, which means all clients in a process share the same configuration. We can introduce some configuration arguments when creating a client.